Remove debug code from transpiled sources. #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referencing #529 here. |
Before this patch, people using itowns as a module (as it should be) had to manually define __DEBUG__ in their own module bundler config, otherwise they had some undefined error. This commit correctly strips itowns out of these debug code during transpilation.
autra
force-pushed
the
babel_strip_debug
branch
from
0ba87f2 to
ff93713
Compare
Closed
|
Thanks @autra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contains 2 commits:
the first one correctly remove debug code from transpiled sources
the second is a basic refactoring
Motivation and Context
Before this patch, people using itowns as a module (as it should be used) had to manually define DEBUG in their own module bundler config, otherwise they had some undefined error. This commit correctly strips itowns out of these debug code during transpilation.